79 switching the validator choice without interrupting the staking process #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vitomir2
commented
Jun 5, 2024
Vitomir2
commented
- new function to swap a delegated position;
- create a new function isBalanceChangeThresholdExceeded in order to check for the maximum amount of swaps (balance changes) allowed;
- new findTopUpIndex, getClosestMaturedTimestamp, and hasMatured functions for the tests;
- adapt the tests, skip the top-up ones by adding todo comments to delete, and add some additional ones to cover cases;
fix bugs and optimize the swap function for the vested delegations; create new function isBalanceChangeThresholdExceeded in order to check for the max amount of swaps (balance changes) allowed; new findTopUpIndex, getClosestMaturedTimestamp and hasMatured functions for the tests; adapt the tests, skip the top-up ones with adding todo comment to delete, and add some additional ones to cover cases;
add more checks in the swap function to avoid some attack vectors; create a separate function to check if the new position is available and revert with general error; delete the top-up tests; cover the new checks in the tests;
R-Santev
approved these changes
Jun 6, 2024
Vitomir2
deleted the
79-switching-the-validator-choice-without-interrupting-the-staking-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.