Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

37 as a user i want to use eip 2612 to approve contracts to spend my lydra #28

Merged
merged 6 commits into from
Jun 7, 2024
Merged

37 as a user i want to use eip 2612 to approve contracts to spend my lydra #28

merged 6 commits into from
Jun 7, 2024

Conversation

SamBorisov
Copy link
Contributor

  1. Added permit functionality on the liquidity token
  2. Add function for (where we use TransferFrom) for cutting position to use permit
  3. Added private function to fulfill the transfer with a permit
  4. Added function for helpers to create signatures for the token
  5. Added test cases for the new function to make sure it works properly

@SamBorisov SamBorisov requested a review from R-Santev June 6, 2024 10:55
@SamBorisov SamBorisov force-pushed the 37-as-a-user-i-want-to-use-eip-2612-to-approve-contracts-to-spend-my-lydra branch from 94862d5 to 1326145 Compare June 6, 2024 14:05
@SamBorisov SamBorisov force-pushed the 37-as-a-user-i-want-to-use-eip-2612-to-approve-contracts-to-spend-my-lydra branch from 41e48df to 0151f5f Compare June 7, 2024 10:37
@SamBorisov SamBorisov merged commit a841bdf into main Jun 7, 2024
1 of 7 checks passed
@SamBorisov SamBorisov deleted the 37-as-a-user-i-want-to-use-eip-2612-to-approve-contracts-to-spend-my-lydra branch June 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Santev R-Santev R-Santev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamBorisov @R-Santev