Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

285 governance consistent logic #85

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Conversation

SamBorisov
Copy link
Contributor

Change Access Control to Whitelisting
Add Governance consistency
Add a modifier and an internal function for readability
Adjust tests

@SamBorisov SamBorisov requested a review from R-Santev November 21, 2024 08:54
@SamBorisov SamBorisov force-pushed the 285-governance-consistent-logic branch from 26de2f9 to 3b858be Compare November 21, 2024 09:02
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 11969285347

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.08%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/HydraVault/HydraVault.sol 0 1 0.0%
Totals Coverage Status
Change from base Build 11956582185: 0.02%
Covered Lines: 1274
Relevant Lines: 1353

💛 - Coveralls

@SamBorisov SamBorisov force-pushed the 285-governance-consistent-logic branch from 1121e63 to 3b4102b Compare November 21, 2024 15:42
@SamBorisov SamBorisov requested a review from R-Santev November 22, 2024 08:45
@SamBorisov SamBorisov merged commit f6b043f into main Nov 22, 2024
7 checks passed
@SamBorisov SamBorisov deleted the 285-governance-consistent-logic branch November 22, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants