Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test #93

Merged
merged 3 commits into from
Jan 16, 2025
Merged

fix test #93

merged 3 commits into from
Jan 16, 2025

Conversation

Vitomir2
Copy link
Contributor

  • commit epochs to enter the maturing phase in the "should successfully calculate the total reward for currently maturing position" test;

@Vitomir2
commit epochs to enter the maturing phase in the "should successfully…
b71770f 
… calculate the total reward for currently maturing position" test
@Vitomir2 Vitomir2 requested a review from SamBorisov January 15, 2025 16:54
@coveralls
Copy link

coveralls commented Jan 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12804000265

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.982%
Totals Coverage Status
Change from base Build 12650395523: 0.0%
Covered Lines: 1231
Relevant Lines: 1326
💛 - Coveralls

SamBorisov
SamBorisov requested changes Jan 16, 2025
View reviewed changes
test/HydraDelegation/VestedDelegation.test.ts
this.fixtures.vestedDelegationFixture
);

// commit epochs and increase time to make the position matured & commit epochs
await commitEpochs(systemHydraChain, hydraStaking, [delegatedValidator], 10, this.epochSize, WEEK);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add check from the contracts, that returns true if position is maturing

@Vitomir2 Vitomir2 requested a review from SamBorisov January 16, 2025 07:21
@Vitomir2 Vitomir2 merged commit 1bec928 into main Jan 16, 2025
7 checks passed
@Vitomir2 Vitomir2 deleted the fix/prev-rps-test-maturing branch January 16, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamBorisov SamBorisov SamBorisov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vitomir2 @coveralls @SamBorisov