[PAUSED] ✨ [MempoolStatusEvent] Add DataProposalPoda mempool status event #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhalex
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
|
wraitii
reviewed
Feb 19, 2025
| @@ -86,6 +86,7 @@ pub enum TransactionTypeDb { | |||
| pub enum TransactionStatusDb { | |||
| WaitingDissemination, | |||
| DataProposalCreated, | |||
| DataProposalPoda, | |||
There was a problem hiding this comment.
Je clarifierais bien que c'est un "local Poda" ou quelque chose - tant qu'on est pas passé dans une lane c'est pas "réel". Pas trop idée du wording... D'autant que cet event pourrait être envoyé plusieurs fois.
There was a problem hiding this comment.
Pour moi une fois qu'on a un poda, ce n'est plus local ? Mais effectivement ça peut être intéressant de garder qqpart tous les events d'updates de podas
hhalex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.