Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Explicit verifier versions #824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BertrandD
Copy link
Contributor

Now the "verifier" value is like "risc0-1.2.3"
you can use hyle-verifiers::RISC0_VERSION to get the value

Now the "verifier" value is like "risc0-1.2.3"
you can use hyle-verifiers::RISC0_VERSION to get the value
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/mempool/verifiers.rs 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
crates/hyle-verifiers/src/lib.rs 13.79% <ø> (ø)
src/genesis.rs 95.19% <100.00%> (ø)
src/mempool/verifiers.rs 56.48% <33.33%> (ø)

... and 8 files with indirect coverage changes

@hhalex
Copy link
Contributor

hhalex commented Feb 25, 2025

Ça me paraît un poil risqué d'utiliser le verifier + version comme nom de verifier?

@BertrandD
Copy link
Contributor Author

Ça me paraît un poil risqué d'utiliser le verifier + version comme nom de verifier?

c'était ce que @wraitii demandait je crois non ?

@BertrandD BertrandD requested a review from wraitii February 25, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants