Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒️ Use keyring to store random private key #826

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BertrandD
Copy link
Contributor

The private key is randomly generated & stored given the validator name
We can set the private key using an hex string in an env var (meant for
kubernetes setup using kube secrets)

In testing env, the private keys are deterministically generated from
the validator name, to keep same behavior as before.

The private key is randomly generated & stored given the validator name
We can set the private key using an hex string in an env var (meant for
kubernetes setup using kube secrets)

In testing env, the private keys are deterministically generated from
the validator name, to keep same behavior as before.
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
src/consensus.rs 84.00% <100.00%> (ø)
src/genesis.rs 95.19% <100.00%> (ø)
src/mempool.rs 86.81% <100.00%> (ø)
src/mempool/storage.rs 74.94% <ø> (ø)
src/single_node_consensus.rs 74.69% <100.00%> (ø)
src/utils/crypto.rs 99.63% <100.00%> (+<0.01%) ⬆️
src/utils/integration_test.rs 92.92% <100.00%> (ø)

Copy link
Contributor

@maxgttph maxgttph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BertrandD BertrandD requested a review from wraitii February 25, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants