-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2: React.lazy
load HyloEditorMobile
for code-splitting to improve load time in HyloApp
#1322
Open
lorenjohnson
wants to merge
6
commits into
HyloApp-544-add-group-explore-and-about
Choose a base branch
from
improve-mobile-editor-performance
base: HyloApp-544-add-group-explore-and-about
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
beafd50
React.lazy loads HyloEditorMobile and moves it above our routing setu…
lorenjohnson 971fbb0
Merge branch 'ssr-code-splitting-and-redux-tidy' into improve-mobile-…
lorenjohnson 5bd9a6e
Merge branch 'ssr-code-splitting-and-redux-tidy' into improve-mobile-…
lorenjohnson 3596b85
Removes HyloEditor dependency on store for Mobile use
lorenjohnson 8aa6d18
Merge branch 'HyloApp-544-add-group-explore-and-about' into improve-m…
lorenjohnson 2b86996
Adds an isolated Feature / ReactPlayer route for HyloApp WebView use
lorenjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,42 @@ | ||
import React from 'react' | ||
import React, { Suspense } from 'react' | ||
import ReactDOM from 'react-dom' | ||
import { rootDomId } from 'client/util' | ||
import App from './router' | ||
import Loading from 'components/Loading' | ||
import './client/websockets' | ||
import './css/global/index.scss' | ||
|
||
ReactDOM.render( | ||
<App />, | ||
document.getElementById(rootDomId) | ||
) | ||
const App = React.lazy(() => import('./router')) | ||
const HyloEditorMobile = React.lazy(() => import('components/HyloEditor/HyloEditorMobile')) | ||
const Feature = React.lazy(() => import('components/PostCard/Feature')) | ||
|
||
const renderRoot = () => { | ||
switch (window.location.pathname) { | ||
case '/hyloApp/editor': { | ||
return ( | ||
<Suspense fallback={() => null}> | ||
<HyloEditorMobile /> | ||
</Suspense> | ||
) | ||
} | ||
|
||
case '/hyloApp/videoPlayer': { | ||
const querystringParams = new URLSearchParams(window.location.search) | ||
|
||
return ( | ||
<Suspense fallback={() => null}> | ||
<Feature url={querystringParams.get('url')} /> | ||
</Suspense> | ||
) | ||
} | ||
|
||
default: { | ||
return ( | ||
<Suspense fallback={() => <Loading type='fullscreen' />}> | ||
<App /> | ||
</Suspense> | ||
) | ||
} | ||
} | ||
} | ||
|
||
ReactDOM.render(renderRoot(), document.getElementById(rootDomId)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh are we still specifically importing fetch? I think I used it 'raw' in a reactions PR... which might be a gap on older browsers (has fetch crossed the line into availability??)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, this file can run on both front and backends....