Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Add Quests and Developer links for Store consumption #431

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

ry-animal
Copy link
Contributor

@ry-animal ry-animal commented Feb 10, 2025

Screenshot 2025-02-10 at 3 57 13 PM Screenshot 2025-02-10 at 3 58 02 PM
Screen.Recording.2025-02-12.at.10.14.41.AM.mov

@BrettCleary @biliesilva fixed some responsiveness at a weird point between tablet and desktop, swapped old twitter logo

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hyperplay-ui ✅ Ready (Inspect) Visit Preview Feb 12, 2025 6:17pm

@ry-animal ry-animal self-assigned this Feb 11, 2025
Copy link
Contributor

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. might need to update the breakpoints in the consuming code.

Also would be good if we could refactor this component to be more general. i.e. take the url's as props and the link text as props as well so we can support translations. We could make it take a list of nav item components so we wouldn't need to send ui lib pr's for small stuff like this

@ry-animal
Copy link
Contributor Author

ry-animal commented Feb 11, 2025

lgtm. might need to update the breakpoints in the consuming code.

Also would be good if we could refactor this component to be more general. i.e. take the url's as props and the link text as props as well so we can support translations. We could make it take a list of nav item components so we wouldn't need to send ui lib pr's for small stuff like this

@BrettCleary I figured this would need some refactoring as a follow up - esp to be able to use with website since currently implementing it there would be a regression since website supports i18n also yes, making it generic would be ideal so don't have to update -ui, then version update deps in the downstream. I'll create a follow up issue to work after some higher prio issues.

Copy link
Contributor

@biliesilva biliesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only change that would be a plus is what Brett mentioned, updating breakpoints, also taking in consideration the distance between the menu and the logo for small screen (give it more breath space).

@ry-animal ry-animal merged commit 70ecc70 into main Feb 13, 2025
3 checks passed
@ry-animal ry-animal deleted the fix/navBarLinks branch February 13, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants