Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inner http client configurable #15

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Make inner http client configurable #15

merged 2 commits into from
Apr 24, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Apr 24, 2024 •
edited
Loading

Fixes Issue

Fixes #14

Changes proposed

  • Make the inner HTTP client configurable / overridable
  • Change backport strategy
  • Update docs

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr lampajr marked this pull request as draft April 24, 2024 14:13
@lampajr lampajr force-pushed the gh14_inner_client_configurable branch from ae66ba2 to 1616aeb Compare April 24, 2024 14:40
@lampajr lampajr marked this pull request as ready for review April 24, 2024 14:41
@lampajr
Copy link
Member Author

lampajr commented Apr 24, 2024

Since we still miss the GET_STARTED guide for this client (see #4), let's update the documentation in a separate pull request

@lampajr lampajr added the backport Backport the pull request to the stable branch label Apr 24, 2024
@lampajr lampajr mentioned this pull request Apr 24, 2024
Merged
6 tasks
@lampajr lampajr self-assigned this Apr 24, 2024
@lampajr lampajr merged commit 013bad8 into Hyperfoil:main Apr 24, 2024
4 checks passed
@lampajr lampajr deleted the gh14_inner_client_configurable branch April 24, 2024 15:56
@github-actions GitHub Actions
Copy link

The backport to 0.12.x failed. Check the latest run for more details.

@lampajr lampajr mentioned this pull request Apr 25, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lampajr lampajr

Labels
backport Backport the pull request to the stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make inner http client overridable
1 participant
@lampajr