Reorganize code for the typed choice sequence #4254
Conversation
|
Nice!
Let's leave an alias for now - it's an unstable but public-ish interface and so I think the small effort is justified. We could use the |
|
(e: both surprised and happy to discover that mypyc behaves correctly here, though I'll have to double check later that we don't lose performance on the entire file as a result) |
tybug
force-pushed
the
tcs-cleanup
branch
2 times, most recently
from
74b86bd to
5fd3349
Compare
| @@ -124,7 +114,6 @@ def __repr__(self) -> str: | |||
| return f"Status.{self.name}" | |||
|
|
|||
|
|
|||
| @dataclass_transform() | |||
| @attr.s(slots=True, frozen=True) | |||
| class StructuralCoverageTag: | |||
There was a problem hiding this comment.
I'm assuming dataclass_transform isn't necessary on our side nowadays - hopefully attrs is applying it to all attrs classes themselves?
|
This also reminded me that primary/secondary are rather non-descriptive names for database keys; per #4155 maybe we can rename to use more-descriptive names? (no suggestions for that yet, though) |
providers.py, includingHypothesisProviderandPrimitiveProvider. I'm trying to structure things better than sticking everything intodata.py, which has become massive (2k lines)AVAILABLE_PROVIDERShas moved fromdata.pytoproviders.py, so (@pschanely) crosshair should update its registration code - or we could leave a compatibility alias indata.py?NodeTemplate->ChoiceTemplate