Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1006):Rewriting Provider Menu page to React #1033

Conversation

adityadeshlahre
Copy link
Contributor

@adityadeshlahre adityadeshlahre commented May 6, 2024

fixes(#1006)

WIP

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

  • providerMenu JSP page to React

Screenshots

image

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@adityadeshlahre
Copy link
Contributor Author

Provider Menu Page workFlow in React

providerMenu

  • try to cover every edgeCase
  • GET/POST request is handled by restController
  • deactivating the provider working
  • workflow is working same as JSP page [ with some updates ]

Thank You 🙂
If any changes required please let me know !

@adityadeshlahre adityadeshlahre marked this pull request as ready for review May 8, 2024 10:38
@github-actions github-actions bot added the merge conflict Merge Conflicts label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict Merge Conflicts and removed merge conflict Merge Conflicts labels May 16, 2024
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@mozzy11
Copy link
Collaborator

mozzy11 commented May 23, 2024

Thanks @adityadeshlahre any progress or blocker on this PR ?

@adityadeshlahre
Copy link
Contributor Author

Thanks @adityadeshlahre any progress or blocker on this PR ?

Hey @mozzy11
just need to fix merge conflicts and do some cleanups good to go.

@adityadeshlahre adityadeshlahre force-pushed the fix-1006-provider-management-rewrite branch from ef3a376 to 41c867c Compare May 23, 2024 08:57
@adityadeshlahre
Copy link
Contributor Author

updated direct call controllers [ working ]

image

image

hey @mozzy11
This pr is ready to merge 🙂

Thank You

@github-actions github-actions bot removed the merge conflict Merge Conflicts label May 24, 2024
@mozzy11
Copy link
Collaborator

mozzy11 commented Jun 6, 2024

Thanks @adityadeshlahre .
More is needed here to implement Pagination . we will also add support for Addning a provider and Modifying a provider

@mozzy11 mozzy11 merged commit e537fad into I-TECH-UW:develop Jun 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants