Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for indexing Patient and Person entities #1095

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

rahul6603
Copy link
Contributor

@rahul6603 rahul6603 commented Jun 13, 2024

Issue - #1049

Summary

  • We will use @Indexed and @*Field (such as @KeywordField) annotations to map Patient and Person entities and their fields to Lucene indexes.
  • We will create a custom normalizer that includes lowercase and ascii-folding filters for the Keyword fields. These filters will convert every character to lowercase and replace characters with diacritics ("é", "à", …​) with their ASCII equivalent ("e", "a", …​).

@rahul6603
Copy link
Contributor Author

Hi @mozzy11 , could you please review this PR?
Thank you.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Jun 17, 2024
Copy link

👋 Hi, @rahul6603,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move the field modification change to its corresponding PR and only leave changes realted to search engine

@rahul6603 rahul6603 marked this pull request as draft June 24, 2024 06:13
@github-actions github-actions bot added the merge conflict Merge Conflicts label Jun 25, 2024
Copy link

👋 Hi, @rahul6603,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rahul6603 rahul6603 marked this pull request as ready for review June 25, 2024 08:14
@rahul6603 rahul6603 requested a review from mozzy11 June 25, 2024 08:16
@mozzy11 mozzy11 merged commit 75fe9c5 into I-TECH-UW:develop Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants