-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Reports #1270
Open
Kevin-Mickael
wants to merge
14
commits into
I-TECH-UW:develop
Choose a base branch
from
pascagihozo:csv_reports
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CSV Reports #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in the rejection controller and a function at the frontend to call that point
mozzy11
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pascagihozo .
Can you write the right SQL queries for the respective reports ??
Hi @mozzy11 I've tried to integrate an SQL query into the StatisticsreportColumnBuilder . For the other reports with a range of dates, I just referenced SampleRejection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
I created all the necessary classes and column builders for the backend. Then, I updated the frontend to reflect these changes. I do some change on the Implementfactory class as well to interact with the frontend.
@mozzy11 @caseyi
Screenshots
Related Issue
When I tried to change the link to "/RoutineReport?type=indicator&report=indicatorHaitiLNSPAllTests", the page failed to display. This issue seems to be related to the classes I created, as the page that should be shown is not rendering correctly after the update.
Other
[Add any additional information or notes here]