-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) CDI-14: Add refresh button to generate IPS if it does not exist. #2
Conversation
…uery backend endpoint for IPS
…ion numbers and make template strings translatable
showSnackbar({ | ||
isLowContrast: true, | ||
kind: 'success', | ||
title: t('ipsCreated', 'IPS bundle generated successfully!'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change this to have the title as 'IPS' and then the subtitle as 'IPS bundle downloaded successfully'
.catch((err) => { | ||
setIps((ps) => ({...ps, history: null, isLoading: false, error: err?.message || "Failed to fetch IPS"})); | ||
setIsSubmitting(false); | ||
showSnackbar({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us maintain the title as just 'IPS'
} | ||
},[error, history, isLoading]) | ||
|
||
console.error(ips); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us remove this.
Requirements
For changes to apps
If applicable
Summary
Screenshots
Related Issue
Other