Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables for combustion and fugitive emissions of fuel supply #209

Conversation

danielhuppmann
Copy link
Member

This PR adds variables to distinguish between fugitive and combustion emissions at the energy-supply-by-fuel resolution, based on a discussion between @volker-krey and Steve Smith related to CEDS and CMIP6 harmonization.

Note that "Emissions|{Level-2 Species}|Energy|Supply|Combustion" and "Emissions|{Level-2 Species}|Energy|Supply|Fugitive" are already included in the template.

@danielhuppmann danielhuppmann requested a review from a team November 12, 2024 10:29
@danielhuppmann danielhuppmann self-assigned this Nov 12, 2024
@strefler
Copy link
Contributor

I'm not sure I'm the right person to review this, I have never really thought about this issue. Maybe rather assign Gunnar?

@danielhuppmann danielhuppmann force-pushed the definitions/emissions-fugitive branch from 705fa01 to fd217b9 Compare November 29, 2024 05:33
@danielhuppmann
Copy link
Member Author

@gidden @jkikstra, do you agree that fugitive vs. combustion emissions should be added in this way?

Note that there are also aggregate fugitive vs. combustion variables at the energy-supply-level, ie

Emissions|{Level-2 Species}|Energy|Supply|Combustion
Emissions|{Level-2 Species}|Energy|Supply|Fugitive

@gidden
Copy link
Member

gidden commented Dec 3, 2024

I see no problem with providing a fuel-specific breakdown of combustion and fugitive emissions if modelling teams have that level of detail

@jkikstra
Copy link
Contributor

jkikstra commented Dec 4, 2024

I also don't have an issue with it.

Originally wasn't planning on adding this as it doesn't seem necessary, but having the freedom to play around with it later may prove to be informative.

@danielhuppmann danielhuppmann force-pushed the definitions/emissions-fugitive branch from 2fb26b6 to d1dc8b7 Compare December 10, 2024 09:08
@danielhuppmann
Copy link
Member Author

Rebased and bumped the tier to 3 for the combustion-vs-fugitive split as it doesn't seem to be a high priority.

@danielhuppmann danielhuppmann merged commit b88e268 into IAMconsortium:main Dec 10, 2024
5 checks passed
@danielhuppmann danielhuppmann deleted the definitions/emissions-fugitive branch December 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants