-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new IamcDataFilter
class
#360
Conversation
At some point it might be nice/necessary to do that. For a first implementation though I'd go for maximum simplicity. If the unit is not what we expect, the numbers will be wrong and it would be caught by the validator anyway. |
8d7c675
to
7909c0a
Compare
Seems like upgrading to matplotlib 3.9.1.post1 does the trick... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, couple of questions/comments below.
Thanks @phackstock for the thorough review. I played around a bit, but it always ended up being way more complicated than it should be, so I concluded that a little bit of duplication is better than a very complex piece of code... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the re-write @danielhuppmann, fully agree with "a little bit of duplication is better than a very complex piece of code" 👍
One small in line comment but good to merge from my side.
Co-authored-by: Philip Hackstock <[email protected]>
This PR is a preparation step for a new DataValidator processor, see IAMconsortium/common-definitions#104
Given the overlap with the already-existing RequiredData processor, the first step is to pull out a common underlying class to collect IAMC-format filters.
In the process, I've been debating with myself whether the DataValidator should support the measurand feature...
Any thoughts @phackstock?