Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI-2625 create driver ci #344
base: develop
Are you sure you want to change the base?
CSI-2625 create driver ci #344
Changes from 7 commits
1ac05dc
6aff2f7
1fe56d8
572dddc
88672c3
0eb3674
1e6d6be
34f9715
057884f
683a5a2
90add39
364b42b
782645f
e6a4b96
1ea7d40
605d016
ed661c5
12050f8
c2fba0b
d640b79
31438ff
6d906c0
31d711b
0827d76
2ba9b3a
36d7a6e
e3aa5d6
f854cb0
b4300ee
7e6c394
684aecc
1c9a227
0477825
3496a4a
a04194b
90f3e06
fb1f865
a4b84c1
8ff6f1c
3b3c0b9
fadd666
cda5430
43aabe1
9bc70b5
a05503f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please choose casing + punctuation convention and align all accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and align all with the stage names accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me clarify - e.g.
prepare env
andCreate-cluster
are not in the same convention, because of whitespace vs.-
, uppercase vs. lowercase, etc...I personally prefer whitespace over
-
, but the main point is for all to be aligned.btw, I know the example yamls dir is currently under a "deploy" dir, but "k8s yamls validation" is not "CSI deployment", it's more "CSI configuration" (the true deployment dir is on the operator side), but I think "k8s yamls validation" is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the case of the first letter is still not unified in the job "keys".
also it is not the same as in the other PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I aligned all the keys now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got it right now, I think I was confused from all the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps I wasn't specific enough (though I don't think I should link to every relevant line):
I still see this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same for unit testing, etc...)
could you align the names to the ones in the jenkinsfile, as much as possible?
unless you know of an easy way to maintain them in one place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would also mean:
k8s yamls validation
should be:K8s yamls validation
(in both files)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you check if this is still needed?