Use POST method for REST transport (#66)

* use POST method for rest transports * enable skipped test cases for `getInstalledProducts()` Signed-off-by: Xu Meng <[email protected]>
IBM · Jul 4, 2019 · 6a9f91f · 6a9f91f
1 parent 014aabf
commit 6a9f91f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/lib/transports/irest.js b/lib/transports/irest.js
@@ -59,8 +59,12 @@ const iRestHttp = (config, xmlInput, done) => {
   const options = {
     host,
     port,
-    path: `${path}?${xmlEnc}`,
-    method: 'GET',
+    path,
+    method: 'POST',
+    headers: {
+      'Content-Type': 'application/x-www-form-urlencoded',
+      'Content-Length': Buffer.byteLength(xmlEnc)
+    }
   };
 
   const request = http.request(options, (response) => {
@@ -78,7 +82,7 @@ const iRestHttp = (config, xmlInput, done) => {
   request.on('error', (error) => {
     done(error, null);
   });
-
+  request.write(xmlEnc);
   request.end();
 };
 

diff --git a/test/functional/ToolkitFunctional.js b/test/functional/ToolkitFunctional.js
@@ -653,9 +653,6 @@ describe('Toolkit Functional Tests', () => {
     transports.forEach((transport) => {
       // eslint-disable-next-line func-names
       it(`returns info for installed products using ${transport.name} transport`, function (done) {
-        if (transport.name === 'rest') {
-          this.skip();
-        }
         const connection = transport.me;
 
         const toolkit = new Toolkit(connection);

diff --git a/test/functional/deprecated/iProdFunctional.js b/test/functional/deprecated/iProdFunctional.js
@@ -129,9 +129,6 @@ describe('iProd Functional Tests', () => {
     transports.forEach((transport) => {
       // eslint-disable-next-line func-names
       it(`returns info for installed products using ${transport.name} transport`, function (done) {
-        if (transport.name === 'rest') {
-          this.skip();
-        }
         const connection = transport.me;
 
         const prod = new iProd(connection);