Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to @use instead of @import #506

Closed
wants to merge 2 commits into from
Closed

Conversation

sora-san45
Copy link

@sora-san45 sora-san45 commented Jan 11, 2023

Related: #309

@ibmdotcom-bot
Copy link
Collaborator

ibmdotcom-bot commented Jan 11, 2023

@sora-san45 sora-san45 marked this pull request as draft January 15, 2023 04:44
@sora-san45 sora-san45 marked this pull request as ready for review January 15, 2023 04:44
@sora-san45
Copy link
Author

@tay1orjones could you check this

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for making this update! Can you confirm this works for you? Maybe through an example stackblitz or something similar?

README.md Outdated
Comment on lines 43 to 44
$font-prefix: './custom/path/to/font/files';
@import 'node_modules/@ibm/plex/scss/ibm-plex.scss';
@use 'node_modules/@ibm/plex/scss/ibm-plex.scss';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will work because @use declarations are required to be the first thing in the file. Defining the $font-prefix variable first will have no impact on the path provided to ibm-plex.scss.

We may need to reconfigure how the scss is generated to support sass module configuration using with

@use 'node_modules/@ibm/plex/scss/ibm-plex.scss' with (
  $font-prefix: './custom/path/to/font/files';
);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, I don't think the above will work with the way the scss is structured right now

@tay1orjones
Copy link
Member

tay1orjones commented Jul 24, 2023

This is outlined in #370, but the entire repo needs to be updated so the output uses @forward and is compatible with the sass module system provided by dart-sass. This change can't be made until that is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants