Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Skip router render meanwhile there is no outlet #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip router render meanwhile there is no outlet #179

wants to merge 1 commit into from

Conversation

abdonrd
Copy link
Member

@abdonrd abdonrd commented Oct 14, 2020

Could fix vaadin/router#495

@abdonrd abdonrd requested a review from Tansito October 14, 2020 09:54
abdonrd
abdonrd commented Oct 14, 2020
View reviewed changes
Copy link
Member Author

@abdonrd abdonrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping to @web-padawan!

src/router/index.ts
},
...routes
],
true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First we skip the router render.

src/router/index.ts

export const attachRouter = (outlet: Node | null): void => {
router.setOutlet(outlet);
router.render(window.location, true);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we force the first render when attach the router.

@web-padawan
Copy link
Contributor

Thanks, now the issue seems more clear to me. I will ask if anyone from our team would have time to look into it.

@abdonrd
Copy link
Member Author

abdonrd commented Oct 14, 2020

Great, thanks @web-padawan!

@abdonrd
Copy link
Member Author

abdonrd commented Oct 16, 2020

@web-padawan have you gotten any response? Thanks in advance!

@web-padawan
Copy link
Contributor

Unfortunately the team is busy with other priorities at the moment. Also, vaadin-router is now part of the Vaadin 15+ which does not support IE11 and old Edge anymore, so we might re-evaluate browser support for the router in future.

I will dedicate some time to investigate this issue on my own, and hopefully come up with a fix for it.

@abdonrd
Copy link
Member Author

abdonrd commented Oct 19, 2020

Ok, thanks @web-padawan!

@abdonrd
Copy link
Member Author

abdonrd commented Oct 27, 2020

@web-padawan have you had a chance to investigate it?

@web-padawan
Copy link
Contributor

Not yet, unfortunately. Sorry about that.
I've been out of context for a while, and will need kind of mental switch to dig into @vaadin/router internals again 🙂

@abdonrd abdonrd force-pushed the fix-router branch 6 times, most recently from 5b5d912 to 0b1cca5 Compare November 18, 2020 09:45
@abdonrd abdonrd force-pushed the fix-router branch 2 times, most recently from 49a85c4 to 4c6b331 Compare November 25, 2020 09:29
@abdonrd abdonrd force-pushed the fix-router branch 2 times, most recently from 5667af5 to 926935c Compare December 9, 2020 15:20
@abdonrd abdonrd force-pushed the fix-router branch 2 times, most recently from 4d6593e to a056971 Compare December 17, 2020 22:03
@abdonrd abdonrd force-pushed the fix-router branch 2 times, most recently from a273957 to f1f6422 Compare January 13, 2021 10:27
@abdonrd abdonrd mentioned this pull request Feb 2, 2021
Open
@abdonrd abdonrd force-pushed the fix-router branch 3 times, most recently from dd608bf to be6d201 Compare February 27, 2021 09:01
@Tansito
Copy link
Contributor

Tansito commented Mar 12, 2021

We don't know if you had time to check something about the proposed solution, @web-padawan thanks!

@abdonrd abdonrd force-pushed the fix-router branch 3 times, most recently from 3b8ded3 to c27d107 Compare April 25, 2021 14:55
@abdonrd abdonrd force-pushed the fix-router branch 3 times, most recently from a3421c8 to f15d2b8 Compare May 5, 2021 18:37
@abdonrd abdonrd force-pushed the fix-router branch 3 times, most recently from 09278fd to 93820b2 Compare June 4, 2021 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tansito Tansito Awaiting requested review from Tansito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Exception thrown and not caught
3 participants
@abdonrd @web-padawan @Tansito