feat(proto): extend isValidVersion for server-only ranges

Co-authored-by: Mark Hindess <[email protected]> Signed-off-by: Dominic Evans <[email protected]>
IBM · Aug 1, 2023 · 031df5d · 031df5d
1 parent 26d9b01
commit 031df5d
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/create_topics_request.go b/create_topics_request.go
@@ -84,7 +84,7 @@ func (r *CreateTopicsRequest) headerVersion() int16 {
 }
 
 func (c *CreateTopicsRequest) isValidVersion() bool {
-	return c.Version >= 0 && c.Version <= 2
+	return c.Version >= 0 && c.Version <= 3
 }
 
 func (c *CreateTopicsRequest) requiredVersion() KafkaVersion {

diff --git a/delete_topics_request.go b/delete_topics_request.go
@@ -43,7 +43,7 @@ func (d *DeleteTopicsRequest) headerVersion() int16 {
 }
 
 func (d *DeleteTopicsRequest) isValidVersion() bool {
-	return d.Version >= 0 && d.Version <= 1
+	return d.Version >= 0 && d.Version <= 3
 }
 
 func (d *DeleteTopicsRequest) requiredVersion() KafkaVersion {

diff --git a/list_groups_request.go b/list_groups_request.go
@@ -25,7 +25,7 @@ func (r *ListGroupsRequest) headerVersion() int16 {
 }
 
 func (r *ListGroupsRequest) isValidVersion() bool {
-	return r.Version == 0
+	return r.Version >= 0 && r.Version <= 2
 }
 
 func (r *ListGroupsRequest) requiredVersion() KafkaVersion {

diff --git a/sasl_handshake_request.go b/sasl_handshake_request.go
@@ -34,7 +34,7 @@ func (r *SaslHandshakeRequest) headerVersion() int16 {
 }
 
 func (r *SaslHandshakeRequest) isValidVersion() bool {
-	return r.Version == 0
+	return r.Version >= 0 && r.Version <= 1
 }
 
 func (r *SaslHandshakeRequest) requiredVersion() KafkaVersion {