fix(fvt): fresh metrics registry for each test

Trying to nail down flakiness with the verification of metrics in these tests. Since adding the additional versions these have been flakey and I think the reason is that the registry is getting re-used between tests as it is only created fresh on a call to NewConfig Signed-off-by: Dominic Evans <[email protected]>
IBM · Aug 21, 2023 · 70c12c0 · 70c12c0
1 parent b4e0554
commit 70c12c0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/functional_producer_test.go b/functional_producer_test.go
@@ -826,8 +826,10 @@ func testProducingMessages(t *testing.T, config *Config, minVersion KafkaVersion
 		name := t.Name() + "-v" + version.String()
 		t.Run(name, func(t *testing.T) {
 			config.ClientID = name
+			config.MetricRegistry = metrics.NewRegistry()
 			checkKafkaVersion(t, version.String())
 			config.Version = version
+
 			client, err := NewClient(FunctionalTestEnv.KafkaBrokerAddrs, config)
 			if err != nil {
 				t.Fatal(err)