Apply suggestions from code review

Co-authored-by: Mark Hindess <[email protected]> Signed-off-by: Dominic Evans <[email protected]>
IBM · Aug 2, 2023 · a9b3318 · a9b3318
1 parent d90c2bd
commit a9b3318
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/add_offsets_to_txn_request.go b/add_offsets_to_txn_request.go
@@ -54,7 +54,7 @@ func (a *AddOffsetsToTxnRequest) headerVersion() int16 {
 }
 
 func (a *AddOffsetsToTxnRequest) isValidVersion() bool {
-	return a.Version == 0
+	return a.Version >= 0 && a.Version <= 2
 }
 
 func (a *AddOffsetsToTxnRequest) requiredVersion() KafkaVersion {

diff --git a/add_partitions_to_txn_request.go b/add_partitions_to_txn_request.go
@@ -78,7 +78,7 @@ func (a *AddPartitionsToTxnRequest) headerVersion() int16 {
 }
 
 func (a *AddPartitionsToTxnRequest) isValidVersion() bool {
-	return a.Version == 0
+	return a.Version >= 0 && a.Version <= 2
 }
 
 func (a *AddPartitionsToTxnRequest) requiredVersion() KafkaVersion {

diff --git a/end_txn_request.go b/end_txn_request.go
@@ -51,7 +51,7 @@ func (r *EndTxnRequest) headerVersion() int16 {
 }
 
 func (a *EndTxnRequest) isValidVersion() bool {
-	return a.Version == 0
+	return a.Version >= 0 && a.Version <= 2
 }
 
 func (a *EndTxnRequest) requiredVersion() KafkaVersion {

diff --git a/init_producer_id_request.go b/init_producer_id_request.go
@@ -85,7 +85,7 @@ func (i *InitProducerIDRequest) headerVersion() int16 {
 }
 
 func (i *InitProducerIDRequest) isValidVersion() bool {
-	return i.Version >= 0 && i.Version <= 3
+	return i.Version >= 0 && i.Version <= 4
 }
 
 func (i *InitProducerIDRequest) requiredVersion() KafkaVersion {

diff --git a/txn_offset_commit_request.go b/txn_offset_commit_request.go
@@ -97,7 +97,7 @@ func (a *TxnOffsetCommitRequest) headerVersion() int16 {
 }
 
 func (a *TxnOffsetCommitRequest) isValidVersion() bool {
-	return a.Version == 0
+	return a.Version >= 0 && a.Version <= 1
 }
 
 func (a *TxnOffsetCommitRequest) requiredVersion() KafkaVersion {