feat(gzip): switch to klauspost/compress gzip #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in #2359, use klauspost/compress for our gzip implementation as we're already using the module for other compression algorithms and benchmarks show 1.5x-7x improvement Signed-off-by: Dominic Evans <[email protected]>
|
@dnwe If possible you shouldn't do testing against compressed output. There is sure to be changes to the output - which would mean an upgrade would break your tests again. |
|
@klauspost yes I'm not really sure what the intention of that unittest was tbh, but for now I just kept it compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #2359, use klauspost/compress for our gzip implementation as we're already using the module for other compression algorithms and benchmarks show 1.5x-7x improvement