Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples): sync exactly_once and consumergroup #2614

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix(examples): sync exactly_once and consumergroup #2614

merged 1 commit into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. fix(examples): sync exactly_once and consumergroup 

    - ensure both examples handle sarama.ErrClosedConsumerGroup in the
  Consume for { ... } loop and ignore that error as it means the user
  has closed the ConsumerGroup directly via Close().
- ensure exactly_once handles the Messages() channel being closed with
  an ok check.
- copy assignment strategy optional flag from consumergroup into
  exactly_once sample
- bump the go.mod of both to specify 1.40.1 by default (although we
  still replace to ../.. anyway)

Signed-off-by: Dominic Evans <[email protected]>
    @dnwe
    dnwe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d4dc7bc View commit details
    Browse the repository at this point in the history