Fix: Update version parsing logic and clean up go warning #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gorgonx7
force-pushed
the
update-version-checking-logic
branch
from
bcfe70d
to
c13de20
Compare
This function was not needed and the logic was a little messy, this should fix that Signed-off-by: James Gordon <[email protected]>
Error strings should not be capitalized Test variable should not be public as sarama only has one package Signed-off-by: James Gordon <[email protected]>
Gorgonx7
force-pushed
the
update-version-checking-logic
branch
from
c13de20
to
dd423dd
Compare
|
Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to clean up the version parsing logic as we didn't need to use a function for such a trivial job, this should both improve performance and code clarity.
I also cleaned up a minor code quality warning where an error string was capitalized and the variable was public, it is now private and not capitalized