Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log SASL connection and handshake errors #2995

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

pierDipi
Copy link
Contributor

@pierDipi pierDipi commented Oct 1, 2024

I'm trying to debug an issue and the logger is only logging:
Error while performing SASL handshake kafka-1:9093 since the
actual error is not logged, it's not clear what went wrong.

Verified that the error doesn't contain sensitive data

Fixes #2994

Addition reference: #2234 (comment)

I'm trying to debug an issue and the logger is only logging:
`Error while performing SASL handshake kafka-1:9093` since the
actual error is not logged, it's not clear what went wrong.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi force-pushed the SARAMA-2994_log-sasl-conn-err branch from cc68fd5 to a721a20 Compare October 1, 2024 13:10
@pierDipi
Copy link
Contributor Author

pierDipi commented Oct 1, 2024

cc @puellanivis @dnwe

Copy link
Contributor

@puellanivis puellanivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calls to .Error() can be dropped for all of the lines of change.

Other than that, everything looks solid.

broker.go Outdated Show resolved Hide resolved
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Copy link
Contributor

@puellanivis puellanivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Just need to confirm that the errors don’t have sensitive info.

Copy link
Collaborator

@dnwe dnwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@dnwe dnwe added the fix label Oct 8, 2024
@dnwe dnwe changed the title Log SASL connection and handshake errors fix: log SASL connection and handshake errors Oct 8, 2024
@dnwe dnwe merged commit f75af48 into IBM:main Oct 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why are SASL Handshake errors not logged ?
3 participants