Fix: Update schemas for Terraform Backwards Compatibility #154

tyao117 · 2024-12-20T21:20:52Z

Made the field ControlSpecificationDescription to Description
Changed Patch for ControlLibrary to use Control rather than ControlPrototype
Changed Attributes from map[string]string to map[string]interface

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

The commit message follows the Angular Commit Message Guidelines.
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

Yes
No

Other information

tyao117 · 2025-01-23T17:08:03Z

integrations tests passing:

 scc-go-sdk/v5/securityandcompliancecenterapiv3 ➜ go test -v -tags=integration                                                                                               on  controls_update [?] via 🐹 v1.22.4 at 11:12:13 AM
=== RUN   TestSecurityAndComplianceCenterV3
Running Suite: SecurityAndComplianceCenterV3 Suite
==================================================
Random Seed: 1736961140
Will run 519 of 519 specs

•••••
------------------------------
• [SLOW TEST:5.055 seconds]
SecurityAndComplianceCenterV3 Integration Tests
/Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:42
  CreateCustomControlLibrary - Create a custom control library
  /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:265
    CreateCustomControlLibrary(createCustomControlLibraryOptions *CreateCustomControlLibraryOptions)
    /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:269
------------------------------
••••••••••••••••
------------------------------
• [SLOW TEST:5.563 seconds]
SecurityAndComplianceCenterV3 Integration Tests
/Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:42
  ReplaceCustomControlLibrary - Update a custom control library
  /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:997
    ReplaceCustomControlLibrary(replaceCustomControlLibraryOptions *ReplaceCustomControlLibraryOptions)
    /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1001
------------------------------
••
------------------------------
• [SLOW TEST:5.326 seconds]
SecurityAndComplianceCenterV3 Integration Tests
/Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:42
  ListProfiles - Get all profiles
  /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1063
    ListProfiles(listProfilesOptions *ListProfileOptions) using ProfilesPager
    /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1078
------------------------------
•••••
•••••••
------------------------------
• [SLOW TEST:11.451 seconds]
SecurityAndComplianceCenterV3 Integration Tests
/Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:42
  CreateTarget - Create a target
  /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1446
    CreateTarget(createTargetOptions *CreateTargetOptions)
    /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1450
------------------------------
••
------------------------------
• [SLOW TEST:6.685 seconds]
SecurityAndComplianceCenterV3 Integration Tests
/Users/xxxxxxxxxx/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:42
  ReplaceTarget - replace a target by ID
  /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1531
    ReplaceTarget(replaceTargetOptions *ReplaceTargetOptions)
    /Users/timothyyao/workspace/public-github/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3/security_and_compliance_center_v3_integration_test.go:1535
------------------------------
••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 519 of 519 Specs in 126.331 seconds
SUCCESS! -- 519 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestSecurityAndComplianceCenterV3 (126.46s)
PASS
ok      github.com/IBM/scc-go-sdk/v5/securityandcompliancecenterapiv3   126.759s

ltebben · 2025-01-23T20:48:41Z

If Control and ControlPrototype are the same can we get rid of one please?

- Made the field ControlSpecificationDescription to Description - Changed Patch for ControlLibrary to use Control rather than ControlPrototype - Changed Attributes from map[string]string to map[string]interface Signed-off-by: Timothy-Yao <[email protected]>

Signed-off-by: Timothy-Yao <[email protected]>

## [5.5.1](v5.5.0...v5.5.1) (2024-12-18) ### Bug Fixes * added missing objects from Minor Update ([#153](#153)) ([ad36577](ad36577)) Signed-off-by: Timothy-Yao <[email protected]>

…ntPrototype Signed-off-by: Timothy-Yao <[email protected]>

- **Breaking Change**: Took out ControlPrototype/ControlSpecificationPrototype/AssessmentPrototype - Made the field ControlSpecificationDescription to Description - Changed Patch for ControlLibrary to use Control rather than ControlPrototype - Changed Attributes from map[string]string to map[string]interface - Added functions and fields missing found from the terraform-provider-ibm - Added missing objects from Minor Update ([#153](#153)) ([ad36577](ad36577)) --------- Signed-off-by: Timothy-Yao <[email protected]> Co-authored-by: sccdeveloper <[email protected]>

## [5.5.2](v5.5.1...v5.5.2) (2025-01-24) ### Bug Fixes * Update schemas for Terraform Backwards Compatibility ([#154](#154)) ([b642125](b642125)), closes [#153](#153)

tyao117 changed the title ~~Updates From Terraform~~ Fix: Update schema for Terraform Backwards Compatibility Jan 14, 2025

tyao117 changed the title ~~Fix: Update schema for Terraform Backwards Compatibility~~ Fix: Update schemas for Terraform Backwards Compatibility Jan 14, 2025

tyao117 force-pushed the controls_update branch from 420b806 to 8d4e18a Compare January 14, 2025 22:35

tyao117 marked this pull request as ready for review January 15, 2025 17:07

tyao117 and others added 6 commits January 24, 2025 11:20

Updates

d9e4f32

- Made the field ControlSpecificationDescription to Description - Changed Patch for ControlLibrary to use Control rather than ControlPrototype - Changed Attributes from map[string]string to map[string]interface Signed-off-by: Timothy-Yao <[email protected]>

adding functions missing

696d343

Signed-off-by: Timothy-Yao <[email protected]>

lint: doing gofumpt

b3203f8

Signed-off-by: Timothy-Yao <[email protected]>

Update version 5.5.0 -> 5.5.1 [skip ci]

c29382e

Signed-off-by: Timothy-Yao <[email protected]>

chore(release): 5.5.1 release notes

c58b90d

## [5.5.1](v5.5.0...v5.5.1) (2024-12-18) ### Bug Fixes * added missing objects from Minor Update ([#153](#153)) ([ad36577](ad36577)) Signed-off-by: Timothy-Yao <[email protected]>

fix: took out ControlPrototype/ControlSpecificationPrototype/Assessme…

2742556

…ntPrototype Signed-off-by: Timothy-Yao <[email protected]>

tyao117 force-pushed the controls_update branch from 53b424c to 2742556 Compare January 24, 2025 17:20

ltebben approved these changes Jan 24, 2025

View reviewed changes

tyao117 merged commit 8fb9904 into main Jan 24, 2025
5 checks passed

tyao117 deleted the controls_update branch January 24, 2025 17:38

sccibm pushed a commit that referenced this pull request Jan 24, 2025

chore(release): 5.5.2 release notes

37fdab1

## [5.5.2](v5.5.1...v5.5.2) (2025-01-24) ### Bug Fixes * Update schemas for Terraform Backwards Compatibility ([#154](#154)) ([b642125](b642125)), closes [#153](#153)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Update schemas for Terraform Backwards Compatibility #154

Fix: Update schemas for Terraform Backwards Compatibility #154

tyao117 commented Dec 20, 2024

tyao117 commented Jan 23, 2025 •

edited

Loading

ltebben commented Jan 23, 2025

Fix: Update schemas for Terraform Backwards Compatibility #154

Fix: Update schemas for Terraform Backwards Compatibility #154

Conversation

tyao117 commented Dec 20, 2024

PR summary

PR Checklist

Current vs new behavior

Does this PR introduce a breaking change?

Other information

tyao117 commented Jan 23, 2025 • edited Loading

ltebben commented Jan 23, 2025

tyao117 commented Jan 23, 2025 •

edited

Loading