Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INS-48489 Bigtable filter plugin #609

Merged
merged 3 commits into from
Nov 19, 2024
Merged

INS-48489 Bigtable filter plugin #609

merged 3 commits into from
Nov 19, 2024

Conversation

pankajkumaribm
Copy link
Collaborator

No description provided.

@pankajkumaribm pankajkumaribm changed the base branch from release-v1.6.1 to main October 28, 2024 15:24
@pankajkumaribm pankajkumaribm force-pushed the release-v1.6.1x branch 3 times, most recently from 1b0247a to f06304a Compare October 28, 2024 15:29
@pankajkumaribm pankajkumaribm force-pushed the release-v1.6.1x branch 2 times, most recently from 5de5ca8 to 74b35cc Compare November 4, 2024 20:26
@VanajaGP
Copy link

VanajaGP commented Nov 7, 2024

All changes look good.

hadarkorny
hadarkorny requested changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@hadarkorny hadarkorny left a comment •
edited by chirag-ibm
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check these tasks before merging this PR.

  • Tested internal build script for offline packages.

  • Documentation reviewed by @ShalakaKulkarni15.

@pankajkumaribm pankajkumaribm force-pushed the release-v1.6.1x branch 9 times, most recently from 2b9fdfa to c165fd0 Compare November 15, 2024 18:56
@ShalakaKulkarni15
Copy link
Collaborator

@hadarkorny, @VanajaGP had already reviewed this PR in my absence.

VanajaGP
VanajaGP approved these changes Nov 19, 2024
View reviewed changes
Copy link

@VanajaGP VanajaGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@pankajkumaribm
Copy link
Collaborator Author

Please check these tasks before merging this PR.

  • Tested internal build script for offline packages. Tested
  • Documentation reviewed by @ShalakaKulkarni15.

@pankajkumaribm
Bigtable plugin filter added
ae9a176 
Signed-off-by: Pankaj Kumar <[email protected]>
@chirag-ibm chirag-ibm merged commit 454ba76 into IBM:main Nov 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarkorny hadarkorny hadarkorny approved these changes

@doryo doryo doryo approved these changes

@chirag-ibm chirag-ibm chirag-ibm approved these changes

@taees-eimouri taees-eimouri taees-eimouri approved these changes

@VanajaGP VanajaGP VanajaGP approved these changes

@devanshah2 devanshah2 Awaiting requested review from devanshah2 devanshah2 is a code owner

@Tal-Daniel Tal-Daniel Awaiting requested review from Tal-Daniel Tal-Daniel is a code owner

@natalygmkibm natalygmkibm Awaiting requested review from natalygmkibm natalygmkibm is a code owner

@apurva-birajdar apurva-birajdar Awaiting requested review from apurva-birajdar apurva-birajdar is a code owner

@itai-g-weather-com itai-g-weather-com Awaiting requested review from itai-g-weather-com itai-g-weather-com is a code owner

@RefaelAdi RefaelAdi Awaiting requested review from RefaelAdi RefaelAdi is a code owner

@PratikshaSonawane PratikshaSonawane Awaiting requested review from PratikshaSonawane PratikshaSonawane is a code owner

@rasikashete3 rasikashete3 Awaiting requested review from rasikashete3 rasikashete3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pankajkumaribm @VanajaGP @ShalakaKulkarni15 @hadarkorny @doryo @chirag-ibm @taees-eimouri @RefaelAdi