zhmc: Restructured sample playbooks #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details:
* Restructured the sample playbooks as follows:
- Renamed them so that the resource they work on appears first in the file
name, and then the action. This orders them in the directory listing in
a more meaningful way.
- Changed the variable that selects the inventory entry from 'host' to
'hmc'.
- Removed the 'cpc_name' variable from the vault file, since it is
different for any HMC anyway, and it is easier to understand if it
does not appear defined by magic. The CPC is now defined in each
playbook with the 'cpc' variable and thus can be overridden from
the command line with '-e cpc=mycpc'.
- Simplified the variable names that specify resource names to remove
'_name' for easier use with the '-e' option.
- Added 'gather_facts: no' to the playbooks.
- Added a zhmc log file 'zhmc.log' to the playbooks.
* Simplifications in the inventory and vault files:
- Added the 'verify' variable to the example vault file.
- Removed 'ansible_connection: local' from the example inventory file
since it is not needed, when the tasks specify 'delegate_to: local'.
- Improved the documentation in the example inventory and vault files.
* Major improvements in the z_systems_administration/zhmc/README.md file
that documents how to use the sample playbooks.
Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/restructure-sample-playbooks
branch
from
bde6ff7
to
f3cdab3
Compare
adn1107
reviewed
Jun 27, 2023
| hosts: | ||
| myhmc13: # must match the key name in the vault file | ||
|
|
||
| myhmc13: # An HMC nickname (must match the nickname in the vault file) | ||
| ansible_host: 10.11.12.13 |
There was a problem hiding this comment.
does this ip address belong to IBM? if yes, maybe just set to something generic like 'your_hmc_ip_address'
adn1107
reviewed
Jul 1, 2023
| hosts: | ||
|
|
||
| myhmc13: # An HMC nickname (must match the nickname in the vault file) | ||
| ansible_host: 10.11.12.13 |
There was a problem hiding this comment.
use generic hostname instead of a specific ip address?
adn1107
reviewed
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see the commit message.
Ready for review and merge.