Fix/bastion host error #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kvm ocp upc enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not safe to assume the bastion host is something that can be accessed by Ansible if
use_internal_bastion == false.In my environment, I'm not using a bastion node at all. As a result, when running the destroy playbook,
04-destroy.yaml, the playbook prematurely fails because it cannot reach thehost: bastionsince a bastion is not defined in my inventory file.As a quick and ugly fix I have been commenting out the bastion section of the
destroy-computesanddestroy-controlsplaybooks to get around this problem. Hopefully this PR resolves this problem for good, my updates don't try to access any bastion hosts unlessuse_internal_bastion == true. I believe the same issue will occur for theadd-new-compute-nodecode path as well, so I made some changes there as well.