Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed scaling and positioning of loading comic #337

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

anikde07
Copy link
Collaborator

#310 Fixed scaling of comics and positioned it to the center of the screen for all resolutions

Copy link
Collaborator

@LeaSeep LeaSeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good - but let Paul finally review it

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether i like it always being in the center of the screen and not specifically on the plot but much more consistent than before.

@@ -908,7 +908,8 @@ server <- function(input,output,session){
waiter <- Waiter$new(
id="data_summary",
Copy link
Collaborator

@PaulJonasJost PaulJonasJost Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id="data_summary",

IDs are not needed anymore, as we want to use the whole screen anyway, this will also lead to the correct background color usage. Should be adjusted in all waiters.

Copy link
Collaborator Author

@anikde07 anikde07 Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the IDs from 6 waiter classes. Could you have a look at it once you are free?
Would I need to issue another pull request or can you merge from this one, once you approve the changes?

Also, I just noticed that the run time checks have failed. I'm not sure how to fix this, since I did not make changes to the lock file, which is supposedly missing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failed test is due to the age of this branch. It has been fixed in develop which is ahead of this branch.
@PaulJonasJost would it be correct procedure to merge develop first into this branch and then merge into develop? Or would this overwrite changes done within this branch?

…ngle-gene visualization did not have a waiter class.
@PaulJonasJost PaulJonasJost merged commit cb9095b into develop Oct 30, 2024
1 check passed
@PaulJonasJost PaulJonasJost deleted the loading_screen branch October 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants