Fixed scaling and positioning of loading comic #337
Conversation
program/shinyApp/server.R
Outdated
| @@ -908,7 +908,8 @@ server <- function(input,output,session){ | |||
| waiter <- Waiter$new( | |||
| id="data_summary", | |||
There was a problem hiding this comment.
| id="data_summary", |
IDs are not needed anymore, as we want to use the whole screen anyway, this will also lead to the correct background color usage. Should be adjusted in all waiters.
There was a problem hiding this comment.
I removed the IDs from 6 waiter classes. Could you have a look at it once you are free?
Would I need to issue another pull request or can you merge from this one, once you approve the changes?
Also, I just noticed that the run time checks have failed. I'm not sure how to fix this, since I did not make changes to the lock file, which is supposedly missing.
There was a problem hiding this comment.
I think the failed test is due to the age of this branch. It has been fixed in develop which is ahead of this branch.
@PaulJonasJost would it be correct procedure to merge develop first into this branch and then merge into develop? Or would this overwrite changes done within this branch?
…ngle-gene visualization did not have a waiter class.
#310 Fixed scaling of comics and positioned it to the center of the screen for all resolutions