Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_package / find_dependency issues with different SuiteSparse versions from amici and ceres #391

Open
dweindl opened this issue Oct 14, 2024 · 0 comments

Comments

@dweindl
Copy link
Member

dweindl commented Oct 14, 2024

With the Ubuntu libceres-dev package (built with SuiteSparse support) and with AMICI>=0.26.2 we have the problem, that both amici and ceres are using CMake's find_package to find SuiteSparse, but both require different versions which doesn't work at the moment. (That's why CI builds have ceres disabled in #388) . Ceres builds without SuiteSparse support work fine.
We probably need to temporarily adjust CMAKE_PREFIX_PATH and clear SuiteSparse_FOUND or KLU_FOUND (or SuiteSparse_DIR, ...) after the first find_package/find_dependency call.

dweindl added a commit that referenced this issue Oct 19, 2024
* Update amici to [8253a97d413cbbcfec335fb50fd1355107804e9e](AMICI-dev/AMICI@8253a97)
* GHA: disable ceres due to #391 
* Address amici deprecations

Mysterious amici errors on GHA, specifically for Weber_BMC2015, not locally reproducible, remain AMICI-dev/AMICI#2491. They already occurred (at least) with amici v0.26.1.

---

git subrepo clone --branch=8253a97d413cbbcfec335fb50fd1355107804e9e --force [email protected]:dweindl/AMICI.git deps/AMICI

subrepo:
  subdir:   "deps/AMICI"
  merged:   "8253a97d"
upstream:
  origin:   "[email protected]:dweindl/AMICI.git"
  branch:   "8253a97d413cbbcfec335fb50fd1355107804e9e"
  commit:   "8253a97d"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant