Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: support user-provided calibration results #1338

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Mar 26, 2024

Currently, the design is that:

  • a user can provide previously-calibrated models as user_calibrated_models
  • PEtab Select will put these models into the candidate space, instead of the uncalibrated versions
  • pyPESTO still needs to skip these models

The purpose is that the path through model space is still reproducible, because models are not skipped.
TODO: fully handle this in PEtab Select, so pyPESTO never sees already-calibrated models, except when it asks PEtab Select for the final results.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.10%. Comparing base (bd4b81b) to head (f221448).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
pypesto/select/method.py 0.00% 14 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (bd4b81b) and HEAD (f221448). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (bd4b81b) HEAD (f221448)
12 7
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1338      +/-   ##
===========================================
- Coverage    83.41%   77.10%   -6.31%     
===========================================
  Files          161      163       +2     
  Lines        13460    13791     +331     
===========================================
- Hits         11228    10634     -594     
- Misses        2232     3157     +925     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Is the functionality provided in petab select already?

Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants