fix: project support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the review ! |
caro3801
approved these changes
Jul 12, 2023
| @@ -366,7 +366,7 @@ protected org.icij.datashare.Objects.IncrementalImportResponse importDocuments( | |||
| checkExtensionProject(projectId); | |||
| checkNeo4jAppStarted(); | |||
| String db = neo4jProjectDatabase(projectId); | |||
| return client.importDocuments(db, request); | |||
| return client.importDocuments(db, projectId, request); | |||
There was a problem hiding this comment.
Just for info, you change here your semantic from index to projectId. As far as I saw, there is no mention of projectId elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
While multiple project had been properly added on the
neo4jside in #37, the extension was still setup to use a single index on the ES side and hence was not properly configuredfor a server usage. This PR adds a proper support of multiproject on the ES side.Changes
datashare-neo4j-extension/srcChanged
indexalongside the projectdatabaseinimportNamedEntities,importDocumentsandexportNeo4jCSVsdatashare-neo4j-extension/neo4j-appRemove
AppConfig.neo4j_projectattributeChanged
ESClient.project_indexattribute, the ES client now takes the index as method argumentsPOST /neo4j-csvs,POST /documents,POST /named-entitiesand underlyingneo4j.core.importfunctions to take the ES index as input