Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling colcon twice and passing CMake args to Acados #25

Merged
merged 7 commits into from
Jul 4, 2024

Conversation

oKermorgant
Copy link
Contributor

Hi,

Thanks for this package that I'll try to use for Acados-based MPC.

In this PR I propose 3 updates that might help distributing the package:

  • pre-clone the acados git repo to make it available for Python install (avoids double call to colcon)
  • download the Tera renderer from CMake. Indeed, if the package is installed system-wide then the user might not have the privilege to write in the expected folder
  • add CMake arguments to forward to Acados (e.g. what solvers to use)

@tpoignonec
Copy link
Member

Thanks, that's a great idea!

I just made the edits compliant with the format CI.

@tpoignonec tpoignonec added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 4, 2024
@tpoignonec tpoignonec merged commit b0fb230 into ICube-Robotics:main Jul 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants