Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spell Checker #103

Merged
merged 49 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
7725c44
CI framework for spell check test
bpaul4 Apr 9, 2024
4c4c7e0
fix some typos
bpaul4 Apr 9, 2024
4b805f3
Fixing typos in idaes_examples/mod
andrewlee94 Apr 12, 2024
2df72cc
Merge branch 'spell-checker' of https://github.com/bpaul4/examples in…
andrewlee94 Apr 12, 2024
516509c
Fixing some missed typos
andrewlee94 Apr 12, 2024
8751550
Fixing more typos
andrewlee94 Apr 12, 2024
85b062f
Adding a couple of exclusions
andrewlee94 Apr 12, 2024
198b519
`documentaiton` should be `documentation`
ksbeattie Apr 13, 2024
96ba049
`varaibles` should be `variables`
ksbeattie Apr 13, 2024
dfa5019
algebriac to algebraic
ksbeattie Apr 13, 2024
4246adb
`relase` should be `release`
ksbeattie Apr 13, 2024
96ab158
`whcih` should be `which`
ksbeattie Apr 13, 2024
06ca417
`addtional` should be `additional`
ksbeattie Apr 13, 2024
dc61ba5
`upadate` should be `update`
ksbeattie Apr 13, 2024
f5626ab
`deafault` should be `default`
ksbeattie Apr 13, 2024
3510eca
`indepedent` should be `independent`
ksbeattie Apr 13, 2024
c3b15d8
`convienience` should be `convenience`
ksbeattie Apr 13, 2024
2781743
`memeory` should be `memory`
ksbeattie Apr 13, 2024
fe65eed
`desriptors` should be `descriptors`
ksbeattie Apr 13, 2024
c3b0603
`Curent` should be `Current`
ksbeattie Apr 13, 2024
1f8c0b2
`coversion` should be `conversion`
ksbeattie Apr 13, 2024
5874218
`intialization` should be `initialization`
ksbeattie Apr 13, 2024
a72ec91
`refered` should be `referred`
ksbeattie Apr 18, 2024
acc1e89
`optmization` should be `optimization`
ksbeattie Apr 18, 2024
011f4c5
`severl` should be `several`
ksbeattie Apr 18, 2024
af4ebe7
`compressio` should be `compressor`
ksbeattie Apr 19, 2024
92dc60a
`consitute` should be `constitute`
ksbeattie Apr 19, 2024
32c2ed3
`auxilliary` should be `auxiliary`
ksbeattie Apr 19, 2024
186f4c3
piecwise -> piecewise
ksbeattie Apr 19, 2024
43a488c
`acitivity` should be `activity`
ksbeattie Apr 19, 2024
a7dfd61
`seperation` should be `separation`
ksbeattie Apr 19, 2024
f9353c5
`temeprature` should be `temperature`
ksbeattie Apr 19, 2024
9cbd847
Fixing some more typos
JavalVyas2000 Apr 19, 2024
afbee99
Fixing some more typos
JavalVyas2000 Apr 19, 2024
59bba8c
Fixing some more typos
JavalVyas2000 Apr 19, 2024
c49f469
Fixing some more typos
JavalVyas2000 Apr 19, 2024
9b3e57a
Update pyproject.toml with more exceptions
bpaul4 Apr 19, 2024
c0cbd90
correct "inturn" to "in turn"
bpaul4 Apr 19, 2024
0a5f9ab
Revert "`compressio` should be `compressor`"
ksbeattie Apr 20, 2024
3f29630
Remove RIPE example exceptions
bpaul4 Apr 25, 2024
cee47bf
Merge branch 'main' into spell-checker
lbianchi-lbl Apr 25, 2024
0f0963a
"Diagnositcs" should be "Diagnostics"
lbianchi-lbl Apr 25, 2024
7054188
"maxmimum" should be "maximum"
lbianchi-lbl Apr 25, 2024
4f57f1f
"discrepency" should be "discrepancy"
lbianchi-lbl Apr 25, 2024
2d37ba7
"auxilaries" should be "auxiliaries"
lbianchi-lbl Apr 25, 2024
f401306
"Stream_lables_leader" should be "Stream_label_leader"
lbianchi-lbl Apr 25, 2024
5703f2a
Add regex to exclude "ser" as it appears in pandas warnings
lbianchi-lbl Apr 25, 2024
028cacd
Try recreating the ngcc init file after changes in 4b805f3f0
lbianchi-lbl Apr 26, 2024
3d4ef04
Update "Ba" exception comment
bpaul4 Apr 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,20 @@ defaults:
shell: bash -l {0}

jobs:
spell-check:
name: Check Spelling
runs-on: ubuntu-latest
steps:
- name: Checkout source
uses: actions/checkout@v3
- name: Run Spell Checker
uses: crate-ci/typos@master

pytest:
# description: Run pytest with dev dependencies
name: pytest (py${{ matrix.python-version }}/${{ matrix.os }})
runs-on: ${{ matrix.runner-image }}
needs: [spell-check]
strategy:
fail-fast: false
matrix:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@
"outputs": [],
"source": [
"# Add the model references to the tag metadata based on the strings above.\n",
"da.upadate_metadata_model_references(m, df_meta)"
"da.update_metadata_model_references(m, df_meta)"
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"It can be useful to visualize the measurement data and estimated uncertainty. The following creates box and whisker plots for each tag based on the data bins. A large number of plots may be created, so to manage them more easily, they are saved as PDFs and merged into a single multi-page PDF document. The deafault file name for the resulting PDF is \"data_plot_book.pdf.\""
"It can be useful to visualize the measurement data and estimated uncertainty. The following creates box and whisker plots for each tag based on the data bins. A large number of plots may be created, so to manage them more easily, they are saved as PDFs and merged into a single multi-page PDF document. The default file name for the resulting PDF is \"data_plot_book.pdf.\""
]
},
{
Expand Down Expand Up @@ -384,7 +384,7 @@
"outputs": [],
"source": [
"# Add the model references to the tag metadata based on the strings above.\n",
"da.upadate_metadata_model_references(m, df_meta)"
"da.update_metadata_model_references(m, df_meta)"
]
},
{
Expand Down Expand Up @@ -413,7 +413,7 @@
"from idaes.core.util.tags import ModelTagGroup\n",
"\n",
"# This function creates a dictionary of streams based of streams based on model arcs. The function\n",
"# also takes an addtional set of stream-like objects for add to the stream dictionary. In this case,\n",
"# also takes an additional set of stream-like objects for add to the stream dictionary. In this case,\n",
"# this is a single unit and the flowsheet doesn't contain any arcs, so we add the economized inlet and\n",
"# outlet ports to the stream dictionary.\n",
"stream_dict = ta.arcs_to_stream_dict(\n",
Expand Down Expand Up @@ -459,7 +459,7 @@
" except KeyError:\n",
" pass\n",
"\n",
"# Any addtional tags can be added. This is required for tags that cannot be systematically generated\n",
"# Any additional tags can be added. This is required for tags that cannot be systematically generated\n",
"# from the model streams.\n",
"recon_tags.add(expr=m.fs.econ.heat_duty[0], name=\"ECON_Q\", format_string=\"{:.3f}\")"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"metadata": {},
"source": [
"## Importing Packages\n",
"We start by importing several standard Python modules for convienience. "
"We start by importing several standard Python modules for convenience. "
]
},
{
Expand Down Expand Up @@ -339,7 +339,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Finally, we introduce a single descriptor for the weighted combination of acitivity and stability. \n",
"Finally, we introduce a single descriptor for the weighted combination of activity and stability. \n",
"By changing the parameter weighting the catalytic portion of the objective function, we can optimize for a range of designs optimizing stability and activity. "
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"source": [
"## Importing Packages\n",
"\n",
"We start by importing several standard Python modules for convienience."
"We start by importing several standard Python modules for convenience."
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,18 @@
"\n",
"In this module, we introduce the **MatOpt** interface for representing material properties and specifying optimization problems. \n",
"\n",
"We have designed the interface with severl goals in mind:\n",
"We have designed the interface with several goals in mind:\n",
"\n",
"1. To **simplify the representation of nanostructured materials,** streamlining the creation of materials optimization problems. \n",
"2. To provide a simple interface so that users **do not need to understand the details of building mathematical optmization models** or the syntax of the Pyomo package. \n",
"2. To provide a simple interface so that users **do not need to understand the details of building mathematical optimization models** or the syntax of the Pyomo package. \n",
"3. To **automate many of the common steps of materials optimization,** speeding up the development of new models. \n",
"\n",
"As an example system, we will consider the minimization of cohesive energy in nanoclusters, recently demonstrated in:\n",
"\n",
"Isenberg, N. M., et al., \"Identification of Optimally Stable Nanocluster Geometries via Mathematical Optimization and Density Functional Theory,\" *Molecular Systems Design & Engineering* 5 (2020): 232-244. DOI: [10.1039/C9ME00108E](https://pubs.rsc.org/en/content/articlelanding/2020/me/c9me00108e#!divAbstract).\n",
"\n",
"We seek to identify the geometry that minimizes the cohesive energy of a nanocluster on the face-centered cubic (FCC) lattice. \n",
"As a model for cohesive energy, we use model based on the square-root of coordination number, refered to as the Tomanek model [[1]](https://journals.aps.org/prb/abstract/10.1103/PhysRevB.28.665).\n",
"As a model for cohesive energy, we use model based on the square-root of coordination number, referred to as the Tomanek model [[1]](https://journals.aps.org/prb/abstract/10.1103/PhysRevB.28.665).\n",
"In the equation below, we define the normalized cohesive energy, as the normalized contribution of the square root of the coordination number. \n",
"\n",
"$$\\hat{E}^{\\text{surf}} = \\frac{1}{N \\sqrt{12}} \\displaystyle \\sum_i \\sqrt{CN_i} $$\n",
Expand Down Expand Up @@ -178,7 +178,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"The MatOptModel additionally hold lists of ***MaterialDescriptor*** objects that define the relevant material desriptors. \n",
"The MatOptModel additionally hold lists of ***MaterialDescriptor*** objects that define the relevant material descriptors. \n",
"By default, several universal site descriptors are pre-defined in the model. \n",
"From these, all other material descriptors can be defined.\n",
"\n",
Expand Down Expand Up @@ -353,7 +353,7 @@
" Default: True\n",
" tilim (float): Optional, solver time limit (in seconds).\n",
" Default: 3600\n",
" trelim (float): Optional, solver tree memeory limit (in MB).\n",
" trelim (float): Optional, solver tree memory limit (in MB).\n",
" Default: None (i.e., Pyomo/CPLEX default)\n",
" solver (str): Solver choice. Currently only cplex or neos-cplex are supported\n",
" Default: cplex\n",
Expand Down
4 changes: 2 additions & 2 deletions idaes_examples/archive/matopt/nanowire_design_src.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"metadata": {},
"source": [
"## Importing Packages\n",
"We start by importing several standard Python modules for convienience. "
"We start by importing several standard Python modules for convenience. "
]
},
{
Expand Down Expand Up @@ -161,7 +161,7 @@
"source": [
"## Building a Model\n",
"\n",
"In this example, we will build a model that maximizes the cohesive energy of the nanowire as an indicator of it's thermal stability. To begin, we start by creating a **MatOptModel** object to hold information about the model. Notice that we use a list of empty atoms as our set of building blocks because we will use a cohesive energy function for semiconductor materials that is indepedent of atom types. Thus, we do not need to specify the types of building blocks in our model."
"In this example, we will build a model that maximizes the cohesive energy of the nanowire as an indicator of it's thermal stability. To begin, we start by creating a **MatOptModel** object to hold information about the model. Notice that we use a list of empty atoms as our set of building blocks because we will use a cohesive energy function for semiconductor materials that is independent of atom types. Thus, we do not need to specify the types of building blocks in our model."
]
},
{
Expand Down
10 changes: 5 additions & 5 deletions idaes_examples/archive/matopt/surface_design_src.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"metadata": {},
"source": [
"## Importing Packages\n",
"We start by importing several standard Python modules for convienience. "
"We start by importing several standard Python modules for convenience. "
]
},
{
Expand Down Expand Up @@ -211,7 +211,7 @@
"source": [
"First, we introduce two rules to fix special sites in the design. \n",
"We fix the bottom two layers of atoms to exist, creating underlying bulk layers above which we will introduce nanostruced defets.\n",
"We also fix an arbitrary atom in the top layer, breaking symetry of the design space and resulting in easier to solve opitmization problems without actually restricting the designs that can be possibly represented. "
"We also fix an arbitrary atom in the top layer, breaking symmetry of the design space and resulting in easier to solve opitmization problems without actually restricting the designs that can be possibly represented. "
]
},
{
Expand Down Expand Up @@ -241,7 +241,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Next, we introduce constraints thtat require atoms to be placed on top of each other, avoiding hollow pockets below the surface. "
"Next, we introduce constraints that require atoms to be placed on top of each other, avoiding hollow pockets below the surface. "
]
},
{
Expand Down Expand Up @@ -311,7 +311,7 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"Next, we define a simple model for the surface energy of nanostructured slabs as a piecwise linear function of coordination number. "
"Next, we define a simple model for the surface energy of nanostructured slabs as a piecewise linear function of coordination number. "
]
},
{
Expand Down Expand Up @@ -473,7 +473,7 @@
"metadata": {},
"source": [
"## Processing Solutions\n",
"Once the model is solved, we can plot the resulting design. However, it is often useful to label atoms according to some auxilliary information. In this case, we would like to label atoms that consitute ideal reactive sites. We loop over the sites and set the atom to S to highlight the sites that are reactive. Then, we can write the Design object to PDB or CFG files for plotting.\n",
"Once the model is solved, we can plot the resulting design. However, it is often useful to label atoms according to some auxiliary information. In this case, we would like to label atoms that constitute ideal reactive sites. We loop over the sites and set the atom to S to highlight the sites that are reactive. Then, we can write the Design object to PDB or CFG files for plotting.\n",
"\n",
"Additionally, we can manipulate the resulting design to better see the periodic pattern. Here, we replicate the design four times to see the periodic pattern. "
]
Expand Down
2 changes: 1 addition & 1 deletion idaes_examples/archive/power_gen/ngfc/NGFC_results.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 15 additions & 3 deletions idaes_examples/archive/power_gen/ngfc/ngfc_flowsheet_src.ipynb

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions idaes_examples/archive/power_gen/rsofc/cpu.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def make_vars(self):
doc="Vent temperature [K]",
)

# Pressue [Pa]
# Pressure [Pa]
self.inlet_pressure = Var(
self.flowsheet().config.time,
initialize=17,
Expand Down Expand Up @@ -283,7 +283,7 @@ def make_vars(self):
def add_material_balances(self):
""" This section is for material balance constraints"""

# Sum of all componenet mole fractions in a stream equals 1
# Sum of all components mole fractions in a stream equals 1
@self.Constraint(
self.flowsheet().config.time,
doc="PureCO2 stream: component mole flow equation",
Expand Down Expand Up @@ -640,7 +640,7 @@ def initialize(blk, outlvl=idaeslog.NOTSET, solver=None, optarg=None):
outlvl : sets output level of initialisation routine

optarg : solver options dictionary object (default={'tol': 1e-6})
solver : str indicating whcih solver to use during
solver : str indicating which solver to use during
initialization (default = 'ipopt')

Returns:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def add_asu(fs):
fs.intercooler_s2.outlet.temperature.fix(310.93) # K (100 F)
fs.intercooler_s2.deltaP.fix(-3447) # Pa (-0.5 psi)

# air seperation unit
# air separation unit
fs.ASU.split_fraction[0, "O2_outlet", "CO2"].fix(1e-10)
fs.ASU.split_fraction[0, "O2_outlet", "H2O"].fix(1e-10)
fs.ASU.split_fraction[0, "O2_outlet", "N2"].fix(0.0005)
Expand Down Expand Up @@ -401,7 +401,7 @@ def add_aux_boiler_steam(fs):
) # enthalpy outlet
fs.bhx2.outlet.enth_mol.fix(
h_bhx2
) # K (100 F) # unfix after initalize and spec Q from cmb
) # K (100 F) # unfix after initialize and spec Q from cmb

fs.bhx1.overall_heat_transfer_coefficient.fix(100)
fs.bhx1.delta_temperature_out.fix(10) # fix DT for pinch side
Expand Down Expand Up @@ -1407,7 +1407,7 @@ def set_guess(fs):
fs.preheat_split.inlet, F=7765, T=700, P=1.04e5, comp=comp_guess, fix=True
)

# Set guess for temp, pressure and mole frac conditions to initalize soec
# Set guess for temp, pressure and mole frac conditions to initialize soec
fs.soec_stack.fuel_inlet.flow_mol[0].fix(5600)
fs.soec_stack.fuel_inlet.temperature[0].fix(1023.15)
fs.soec_stack.fuel_inlet.pressure[0].fix(1.01325e5)
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading