Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas deprecation for series call #110

Closed
wants to merge 4 commits into from

Conversation

agarciadiego
Copy link
Contributor

@agarciadiego agarciadiego commented Apr 26, 2024

Removes FutureWarning deprecation message on parmest notebooks on how the elements of the dataframe/dictionary are indexed

Fixes #108

Changes the way of calling the data and differentiates between a dictionary and a dataframe. Based on parmest examples in Pyomo repo

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

📚 Documentation preview 📚: https://idaes-examples--110.org.readthedocs.build/en/110/

@agarciadiego agarciadiego marked this pull request as draft April 26, 2024 19:03
@bpaul4
Copy link
Contributor

bpaul4 commented Apr 29, 2024

Hi @agarciadiego, the number of lines changed seem to be inflated because of the regenerated notebook output. Could you please elaborate on what specific sections are updated in the PR?

There also seem to be some file conflicts.

@lbianchi-lbl
Copy link
Contributor

Hi @agarciadiego, the number of lines changed seem to be inflated because of the regenerated notebook output. Could you please elaborate on what specific sections are updated in the PR?

There also seem to be some file conflicts.

@bpaul4 thanks for bringing this up. I'm working with @agarciadiego to understand why these conflicts are showing up. I've already (unsuccessfully) tried to solve the conflicts locally, so it's likely that I'll open a new PR.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label May 2, 2024
@andrewlee94
Copy link
Member

@agarciadiego What is the status of this PR? Is it something for the May release?

@agarciadiego
Copy link
Contributor Author

@agarciadiego What is the status of this PR? Is it something for the May release?

I'll try to get it merged early next week

@agarciadiego
Copy link
Contributor Author

Replaced by #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas deprecation warnings in parameters estimation notebooks
5 participants