-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the HDA example exercise and solution #62
Updated the HDA example exercise and solution #62
Conversation
@lbianchi-lbl, I changed a couple of files in the HDA_flowsheet example. The files shows changes likes
I am not sure why this is the case. The change that I actually did is around the line 993. |
idaes_examples/notebooks/docs/flowsheets/hda_flowsheet_with_distillation_exercise.ipynb
Outdated
Show resolved
Hide resolved
@JavalVyas2000 thanks for noticing and asking. Those metadata changes are automatically applied to This can be a little confusing and we've been discussing internally to set up some infrastructure so that they don't appear in the diff, but we don't have it set up yet, so for the time being, feel free to ignore them (both as an author and a reviewer). |
I've just realized that this PR is making changes on the |
@MAZamarripa @agarciadiego feel free to add some details about the scope and planned timeline for this work. |
…Vyas2000/IDAES-examples into updated-HDA_initialization
@lbianchi-lbl I did a quick test of pre-processing a re-saved notebook, e.g. make a small change to @andrewlee94 I'll take a look at the Initilalizer docs and update the HDA with Distillation notebook. Once we're happy with that, I am happy to update other tutorial or example notebooks as needed and push them to this same PR. |
@JavalVyas2000 @bpaul4 should this be on the Aug release board? |
Yes. I am working on this. Should be done by then. |
…Vyas2000/IDAES-examples into updated-HDA_initialization
…-HDA_initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of minor requests for changes.
idaes_examples/notebooks/docs/flowsheets/hda_flowsheet_with_distillation.ipynb
Outdated
Show resolved
Hide resolved
idaes_examples/notebooks/docs/flowsheets/hda_flowsheet_with_distillation.ipynb
Outdated
Show resolved
Hide resolved
idaes_examples/notebooks/docs/flowsheets/hda_flowsheet_with_distillation.ipynb
Outdated
Show resolved
Hide resolved
idaes_examples/notebooks/docs/flowsheets/hda_flowsheets_for_costing_notebook.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @JavalVyas2000!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated the hda_flowsheet_with_distillation_exercise.ipynb and hda_flowsheet_with_distillation_solution.ipynb files for the unit models initialization. Changed the function "function" used for initialization to accommodate for the newer initialization method "fix_initialization_states" where the inlet variables are fixed.
📚 Documentation preview 📚: https://idaes-examples--62.org.readthedocs.build/en/62/