Updating NGCC Flowsheet #98
Conversation
|
@JavalVyas2000 news? |
| @@ -0,0 +1,116 @@ | |||
| WARNING: Params with units must be mutable. Converting Param | |||
There was a problem hiding this comment.
What is this results.txt file that has been added to the HDA and methanol flowsheets? Is this relevant to the NGCC flowsheet?
There was a problem hiding this comment.
No. This was something which I was testing out with. I removed it from this PR.
| @@ -107,7 +114,8 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 4, | |||
| "execution_count": null, | |||
There was a problem hiding this comment.
I noticed that none of the cells have been executed in this notebook. All the other example notebooks I've seen have their cells executed, but I'm not sure if this ultimately matters or not.
There was a problem hiding this comment.
@andrewlee94 Should the cells be executed before this is approved?
There was a problem hiding this comment.
That is more a question for @lbianchi-lbl. I do not know exactly how things get run and generated.
I suspect that @JavalVyas2000 needs to run the idaesx commands to generate the full set of docs which would fill these in for him.
|
@JavalVyas2000 any news on this? |
| "metadata": {}, | ||
| "source": [ | ||
| "# NGCC Baseline and Turndown\n", | ||
| "Maintainer: John Eslick \n", |
There was a problem hiding this comment.
Should we think about changing the maintainer?
| "# NGCC Baseline and Turndown\n", | ||
| "Maintainer: John Eslick \n", | ||
| "Author: John Eslick \n", | ||
| "Updated, 2023-06-01 \n", |
There was a problem hiding this comment.
Please update the date here.
Updating NGCC Flowsheet
This PR updates and moves the NGCC flowsheet from active/pow_gen to notebooks/doc/flowsheets/pow_gen.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--98.org.readthedocs.build/en/98/