Python3 support #99
Python3 support #99
Conversation
If the network was unreachable, the loop for sending the broadcast was being performed infinitely, because the payload 'request' could not shrink
Hash ends with a null byte too, so we remove this null byte.
The `.decode('utf-8')` is safe because hash holds an hex value,
which is obviously ascii.
(for using type() builtin function)
hashset yields an error (3rd argument is not void const*). See https://github.com/idapython/src/blob/master/swig/netnode.i#L162: using now hashset_buf
On my ArchLinux, sys.platform returns 'linux', not 'linux2' :-D
When a client connects, he does not write anything, but the QT write notifier was enabled. This case was not properly handled by the _notify_write method
It returns a true string instead of bytes
|
Hi @elp0t0r1c0, thank you very much for your work! I’m currently testing all the features, I will continue to work from there. Feel free to continue on your side too! |
|
Hi @elp0t0r1c0, I’m also interested by your point of view @NeatMonster. |
|
Since all network packets are JSON objects, I don't see why dropping Python 2 support would change anything in that regard. I would advise to keep the Python 2/3 compatibility, but drop support for older versions of IDA Pro. |
|
Ok, I was trying to do things wrong just above, and with this comprehension I though it would need a lot of changes. I was wrong, and effectively it seems that dropping python2 will not change anything, except adding some wrapper as it’s already the case for the Event part. My bad, thanks @NeatMonster! |
I've tried the following things which work:
I haven't tried to use it with other people, because I do not have friends yet (wip).