Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Write radio sound files from pbo to temp folder (drop b64) #978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PabstMirror
Copy link
Collaborator

Copy radio sounds directly from pbo instead of loading b64 files
I'm really not sure if this is a good idea or not

Plus:

  • fix "b64" not allowed errors (server config)
  • easier to add custom radio sounds
  • can cleanup all the b64 code

Negative:

  • Might break something?
  • breaks old custom b64 radio sounds

@NouberNou
Copy link
Member

So yea, there is no reason we have to use b64 still, since it was a relic of the pre-pbo code. Also I don't think there is a need to copy them to a temp folder. We are storing them and playing them from memory in the sound system if I remember right. We should be able to just pass a path from Arma to the extension and pull it into memory from the pbo like we do with the wrps.

@NouberNou
Copy link
Member

I think we should leave the old b64 functionality though imo to have backwards compat.

@NouberNou NouberNou marked this pull request as ready for review June 11, 2020 18:08
Copy link
Member

@NouberNou NouberNou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments.

file_entry() {};
file_entry(file_p entry_) : _file(entry_) {
file_entry() = delete;
file_entry(file_p entry_) : _file(entry_) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file_entry(file_p entry_) : _file(entry_) {
explicit file_entry(file_p entry_) : _file(entry_) {


namespace acre {
namespace pbo {
class file_entry {
public:
file_entry() {};
file_entry(file_p entry_) : _file(entry_) {
file_entry() = delete;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to delete. Simply delete the constructor.

Suggested change
file_entry() = delete;
file_entry() = delete;

@PabstMirror PabstMirror changed the title Write radio sound files from pbo to temp folder (drop b64) WIP: Write radio sound files from pbo to temp folder (drop b64) Jul 8, 2020
@PabstMirror PabstMirror modified the milestones: 2.8.0, Ongoing Jul 8, 2020
@jonpas jonpas modified the milestones: Ongoing, Backlog Feb 24, 2021
@jonpas jonpas added the WIP label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants