Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont walk arrays #11

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Dont walk arrays #11

merged 6 commits into from
Sep 25, 2023

Conversation

will-moore
Copy link
Member

NB: this is on top of #9.

Fixes #10.

This avoids traversing all the chunk directories under .zarray directory, which we know will only contain chunks.

@will-moore
Copy link
Member Author

will-moore commented Sep 20, 2023

Testing... installed on idr-testing.

(venv3) [root@test120-omeroreadwrite wmoore]# pip install git+https://github.com/will-moore/omero-mkngff.git@dont_walk_arrays

And on idr0125-pilot:

(venv3) [root@pilot-idr0125-omeroreadwrite wmoore]# pip install git+https://github.com/will-moore/omero-mkngff.git@dont_walk_arrays
Collecting git+https://github.com/will-moore/omero-mkngff.git@dont_walk_arrays
  Cloning https://github.com/will-moore/omero-mkngff.git (to revision dont_walk_arrays) to /tmp/pip-req-build-a9c45z58
  Running command git clone -q https://github.com/will-moore/omero-mkngff.git /tmp/pip-req-build-a9c45z58
  Running command git checkout -b dont_walk_arrays --track origin/dont_walk_arrays
  Switched to a new branch 'dont_walk_arrays'
  Branch dont_walk_arrays set up to track remote branch dont_walk_arrays from origin.
  Resolved https://github.com/will-moore/omero-mkngff.git to commit 7db8b499708112ea3f250c1bbf82e920c269d8d3

@will-moore
Copy link
Member Author

Updated again on idr-testing and idr0125-pilot to include last commit.

@will-moore
Copy link
Member Author

Tested today with idr0013. IDR/idr-metadata#644 (comment)
3 minutes per fileset

@will-moore
Copy link
Member Author

For info about that last commit, see IDR/idr-metadata#644 (comment)

@joshmoore joshmoore merged commit 90c4dde into IDR:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql performance
2 participants