Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(valhalla): increase isochrone limits in valhalla config #77

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

azarz
Copy link
Member

@azarz azarz commented Mar 18, 2024

The default values for isochrone contours in valhalla are 2 hours and 200 km. In order to compute the same isochrones in valhalla that we did in pgRouting, we need to increase this limit.

Once this is done, there will be no further need for isochrones in pgRouting, and we could deactivate them in our webservices if needed in case of big sollicitations.

@azarz azarz requested review from lgrd and jmkerloch March 18, 2024 15:02
@azarz azarz changed the title feat(valhalla): increasse isochrone limits in valhalla config feat(valhalla): increase isochrone limits in valhalla config Mar 18, 2024
Copy link

github-actions bot commented Mar 18, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1051 402 38% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
r2gg/about.py 100% 🟢
r2gg/_main.py 29% 🟢
TOTAL 65% 🟢

updated for commit: 75321a9 by action🐍

Copy link
Collaborator

@lgrd lgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the version ? ^^

@azarz azarz force-pushed the feature/valhalla-isochrone-limits branch from 8950fe6 to 75321a9 Compare March 18, 2024 16:52
@azarz
Copy link
Member Author

azarz commented Mar 18, 2024

could you update the version ? ^^

Done ! ;)

@azarz azarz requested a review from lgrd March 18, 2024 16:52
@azarz azarz merged commit 7b3c138 into develop Mar 18, 2024
5 checks passed
@azarz azarz deleted the feature/valhalla-isochrone-limits branch March 18, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants