adding browser iteration in actions YAML

IGS · Dec 7, 2023 · 3b620e7 · 3b620e7
1 parent 0a688aa
commit 3b620e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/mocha_tests.yml b/.github/workflows/mocha_tests.yml
@@ -1,5 +1,6 @@
 # Runs mocha tests
 # Tests are built to run on 5 browser modes (chrome, firefox, webkit/safari, iPhone, Pixel)
+# Normally, each test is built to loop through all 5 modes, but if hooks fail, the test will stop
 
 # TODO: Set user/pass secret to send to mocha tests
 
@@ -25,15 +26,19 @@ jobs:
   test:
     timeout-minutes: 60
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        browser: [chromium, firefox, webkit, iphone, pixel]
     steps:
     - uses: actions/checkout@v3
     - uses: actions/setup-node@v3
       with:
-        node-version: 18
+        node-version: 20
     - name: Install dependencies
       run: npm ci
     - name: Install Playwright browsers
       run: npx playwright install && npx playwright install-deps
     - name: Run Mocha tests
       run: npm test # alias to "mocha test"
-      continue-on-error: true
+      env:
+        BROWSER: ${{ matrix.browser }}
diff --git a/tests/test/gene_collection_manager.test.js b/tests/test/gene_collection_manager.test.js
@@ -57,7 +57,7 @@ const login = async (page) => {
 
 describe('Gene Collection Manager', function () {
 
-    this.timeout(10000);    // default is 2000
+    //this.timeout(10000);    // default is 2000
 
     let browserIndex = 0;