Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds accessibility enhancements #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds accessibility enhancements #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d1005
add alt attribute to img thumbs
mejackreed Aug 3, 2017
6bc4ee7
add aria labels for form elements that are unlabeled
mejackreed Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/GalleryComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ namespace IIIFComponents {
this._$rightOptions = $('<div class="right"></div>');
this._$header.append(this._$rightOptions);

this._$sizeDownButton = $('<input class="btn btn-default size-down" type="button" value="-" />');
this._$sizeDownButton = $('<input class="btn btn-default size-down" type="button" value="-" aria-label="Reduce Thumbnail Size"/>');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revise this to make the text i18n-friendly. I believe the way to do this is to add strings to the content element returning IGalleryComponentData in the data() method. Then the values can be overridden in the UV's getGalleryData method.

this._$leftOptions.append(this._$sizeDownButton);

this._$sizeRange = $('<input type="range" name="size" min="1" max="10" value="' + this.options.data.initialZoom + '" />');
this._$sizeRange = $('<input type="range" name="size" min="1" max="10" value="' + this.options.data.initialZoom + '" aria-label="Change Thumbnail Size"/>');
this._$leftOptions.append(this._$sizeRange);

this._$sizeUpButton = $('<input class="btn btn-default size-up" type="button" value="+" />');
this._$sizeUpButton = $('<input class="btn btn-default size-up" type="button" value="+" aria-label="Increase Thumbnail Size"/>');
this._$leftOptions.append(this._$sizeUpButton);

this._$multiSelectOptions = $('<div class="multiSelectOptions"></div>');
Expand Down Expand Up @@ -422,7 +422,7 @@ namespace IIIFComponents {
if (visible !== "false") {
$wrap.addClass('loading');
const src: string = $thumb.attr('data-src');
const $img: JQuery = $('<img class="thumbImage" src="' + src + '" />');
const $img: JQuery = $('<img class="thumbImage" src="' + src + '" alt=""/>');
// fade in on load.
$img.hide().load(function () {
$(this).fadeIn(fadeDuration, function () {
Expand Down Expand Up @@ -596,4 +596,4 @@ namespace IIIFComponents.GalleryComponent {
} else {
g.IIIFComponents.GalleryComponent = IIIFComponents.GalleryComponent;
}
})(global);
})(global);