WIP: fix some Intent filters #621
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
le-jeu
force-pushed
the
iitc_scheme
branch
3 times, most recently
from
64b82b2 to
2006584
Compare
modos189
reviewed
Mar 11, 2023
| @@ -43,29 +43,25 @@ | |||
| <!-- Handles the implicit intent to VIEW the intel.ingress.com/ URI --> | |||
| <intent-filter> | |||
| <action android:name="android.intent.action.VIEW"/> | |||
| <action android:name="android.nfc.action.NDEF_DISCOVERED"/> | |||
There was a problem hiding this comment.
This is not required for NFC to work? I don't have the proper device to test
There was a problem hiding this comment.
I'm playing around trying to figure why some apps are fine with urls, and why iitc isn't
modos189
reviewed
Mar 11, 2023
| <data android:scheme="http"/> | ||
| <data android:scheme="https"/> | ||
| <data android:host="intel.ingress.com"/> | ||
| <data android:scheme="http" android:host="intel.ingress.com"/> |
There was a problem hiding this comment.
As far as I remember, it follows from the documentation that the previous version also works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.