Fix/cache render details #794
Open
+60
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
modos189
reviewed
Jan 11, 2025
| @@ -64,14 +64,19 @@ var handleResponse = function (deferred, guid, data, success) { | |||
| } | |||
|
|
|||
| if (success) { | |||
| // Parse portal details | |||
| var dict = window.decodeArray.portal(data.result, 'detailed'); | |||
| cache.store(guid, dict); | |||
There was a problem hiding this comment.
The data is cached twice, is this done on purpose?
modos189
reviewed
Jan 11, 2025
| var portalData; | ||
|
|
||
| // If the portal was cleared then exit. | ||
| if (window.selectedPortal === null) return; | ||
|
|
||
| portalData = window.portalDetail.get(window.selectedPortal); | ||
| portalData = data.portalData; |
There was a problem hiding this comment.
Is this change about code improvement (decoupling plugins from cache) rather than fixing a bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify
renderPortalDetails: its selects, refresh and render portal details.Split it in a select/refresh part and render part.
Revert part of fa3dddd
Invalidate cache entry if map data is inconsistent with portal details. (from map_data_render)
Hook portal details rendering on
portalAddedandportalDetailLoadedeventUse hook data in unique/machina-tools plugins instead of using
portalDetail.get.I'm not satisfied with the data flow I've made for the permanent portal markers, as data is store in two places (portal marker and cache) and
createPortalEntityis used to parse data for map data and portal details.This fix a bit this issue by parsing portal details twice but it feels wrong to me.