Network Interceptor for noticeboard mobile #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justary27
requested changes
Feb 21, 2024
noticeboard/ios/build/ios/Pods.build/Release-iphonesimulator/Firebase.build/dgph
Outdated
Show resolved
Hide resolved
noticeboard/ios/build/ios/Pods.build/Release-iphonesimulator/FirebaseCore.build/dgph
Outdated
Show resolved
Hide resolved
All changes are as follows: I have updated the web view flutter package to 4.7.0 and upgraded flutter version to 3.19 because reloading the webview requires a webview controller, also added another stream for this purpose
justary27
requested changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Problem
There is notification to the user if their device goes offline, only generic errors were shown
Technicalities of change
I have made a connectivityStatusBloc with a enum for network connection status. In the root of the app , I have passed the context of the material app to the connectivityStatusBloc because it will always be mounted on the widget tree regardless of current widget. My connectivityStatusBloc class is a singleton because there should only be one instantiation of the stream wherever it gets called (We don't want individual network streams for widgets). Hence , it will always be able to render snackbar's succesfully. I have made two functions. One for checking the connectivityStatus using InternetAddress.lookup function of dart:io and have made it a recurring function every 15 seconds until the widget doesn't dispose. I have also made a function to send the required result into the connectivityStatusBloc event sink which manages the snackbars.
For refetch:
There are two types of refetch. One is refetching list of notices, other is reloading the notice detail webview. To reload a web view, we need a webViewController. To do that, I had to upgrade flutter to 3.19.1 and webview_flutter to 4.7.0. I made a NoticeDetailBloc (another stream) which is fed events when user is back online by connectivityStatusBloc based on current position. The reqd widgets listen to the sink of this stream and refetch the required objects.
Note to reviewer
Please squash and merge.
Will fix the GH workflow in another PR. It will fail as I have upgraded flutter version to 3.19.1
Demo
Two videos are attached one for notices list refetch and one for notice detail refetch
2024_02_26_13_46_11.1.mp4
2024_02_26_13_47_29.1.mp4